Open
Conversation
Collaborator
|
Looks good to me but this is somewhat significant behavior change so let's get other people chime in. |
Owner
|
The PR here does more than just make I wonder if it would make sense to bring things together, by getting rid of File::Which, and setting up all the paths in That way we can maintain current precedence rules, apart from moving POSTGRES_HOME to the front. ie. |
Collaborator
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At present POSTGRES_HOME is ineffective if a Postgres is found in PATH. This makes POSTGRES_HOME take precedence so PATH can always be overridden.