Conversation
| elif observation_payload['last_obs_start']: | ||
| new_start = observation_payload['last_obs_start'] + timedelta(hours=advance_window_hours) | ||
| else: | ||
| new_start = parse(observation_payload[start_keyword]) + timedelta(hours=advance_window_hours) |
There was a problem hiding this comment.
I worry about the window length being limited to the length of the observation because if it is a short exposure that isn't constantly visible, it will clutter up the runcadencestrategies log with visibility errors as it keeps attempting to schedule it. This also might be tricky with many observations because it's more observations being scheduled for the same window instead of giving the scheduler room to avoid failures. Maybe a combination of this more robust check for scheduled start/end method and a user defined from the settings file for the minimum window
There was a problem hiding this comment.
This is definitely the right direction though, and cluttering runcadencestrategies log is not the worst thing in the world. Maybe a future improvement would be to combine with the method in #1492 to allow the observing window to be increased or defined elsewhere
2 participants
No description provided.