Open
Conversation
phycodurus
approved these changes
May 1, 2026
jchate6
requested changes
May 7, 2026
Contributor
jchate6
left a comment
jchate6
left a comment
There was a problem hiding this comment.
A few ideas for minor improvements.
| label="P2 password", | ||
| help_text="Enter your Phase 2 Tool password. Leave blank to keep unchanged." | ||
| help_text="Enter your Phase 2 Tool password. Leave blank to keep unchanged.", | ||
| widget=forms.PasswordInput(render_value=True) |
Contributor
There was a problem hiding this comment.
Is there a way to add a revelation option to the form as well? It feels weird to be able to edit this field without seeing what you are typing...
| <input | ||
| type="password" | ||
| readonly | ||
| value="{{ field_data.value }}" |
Contributor
There was a problem hiding this comment.
This would benefit from an eye symbol off to the right to let people know more obviously that they can reveal the password without hovering for a second.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hides the password on the profile page, making the password on revealed on click.
Also uses a proper password widget on the actual update form.
Solves TOMToolkit/tom_base#1451 for this app, at least.