[WIP] Compute IHVP on full dataset instead of summing batch inverses#241
Open
Huining-Wang wants to merge 9 commits intoTRAIS-Lab:mainfrom
Open
[WIP] Compute IHVP on full dataset instead of summing batch inverses#241Huining-Wang wants to merge 9 commits intoTRAIS-Lab:mainfrom
Huining-Wang wants to merge 9 commits intoTRAIS-Lab:mainfrom
Conversation
TheaperDeng
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Correct the scaling in the IHVP computation for the explicit, cg, LiSSA solvers.
Below are the results before and after the scaling correction.
Explicit
before
after
CG
before
after
LiSSA
before
after