Closed
Conversation
92e2e2b to
1738e29
Compare
hmenke
commented
Oct 9, 2023
hmenke
commented
Aug 16, 2024
hmenke
commented
Aug 16, 2024
hmenke
commented
Aug 16, 2024
Member
Author
hmenke
left a comment
There was a problem hiding this comment.
Can we make this non-MPI compatible?
hmenke
commented
Aug 16, 2024
Closed
7a4661b to
9b51e65
Compare
Wentzell
approved these changes
Oct 3, 2025
Member
|
Thank you also @Thoemi09 for your improvements |
hmenke
commented
Oct 3, 2025
Member
Author
hmenke
left a comment
There was a problem hiding this comment.
LGTM, but could you please not squash on merge? This makes it much easier to bisect later if something is wrong. You can clean up the history and rebase on unstable if you want.
Member
I would have been ok with a full squash, but if you want group things into a few commits along the way, feel free to create a suggested a grouping. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All tests were run with multiple nodes and different number of slots on each node:
Some ideas:
MPI allocatorSimilar to
std::allocatorimplement ashared_allocatorand adistributed_shared_allocator, such that one can use e.g.std::vector<double, mpi::shared_allocator<double>>Questions:
split_shared()on the default communicator, but for distributed shared memory there needs to be internode communication and that is not easily guessed from the default communicator. Maybe a global hash table with allocation information is needed?On top of that, for distributed shared memory access must be fenced and broadcasted between nodes. That's not so easy to abstract away.