Adds Automatic Support to Not Use Multipart Uploads If File Size <= partSize

[bikeath1337]

Thanks to @jakubzitny for #362.

This PR has not be tested yet, but specs pass (I will remove the WIP after doing more testing).

What this intends to do: Enhance Evaporate to avoid the overhead of using multipart uploads if the file size is equal to the part size. This option avoids two round trips to AWS (initiate and complete).

Description:

• The feature is enabled by default. To disable, use the provided option enablePartSizeOptimization
• The started, progress and complete callbacks should all be invoked
• computeContentMd5 should be respected
• Retry features should be maintained

Changes:

• The complete callback's xhr parameter will be undefined.

[jakubzitny]

Hey @bikeath1337, so I found some time to try this out and plugged this branch into our code. However I am getting SignatureDoesNotMatch errors. Not sure if there are some differences in auth when using Multipart or this simple PUT API. We're using the customAuthMethod for signing requests.

I'll try a simpler example to see if that works.

EDIT: Yeah I seem to be getting the same for the simple example. Let me dig into it some other time again 😛

[bikeath1337]

Hi, @jakubzitny , I'm back from being away... :) Any update on this?

[fer90]

However I am getting SignatureDoesNotMatch errors

Hey there! I know this is SUPER old, but for anyone trying to do the same thing => I applied this changes to the evaporate lib in my project in order to improve performance a little bit and, hopefully, get rid of a sporadic bug in an already deprecated ( 😞 ) MinIO gateway, and I figured the SignatureDoesNotMatch error arises because the string to sign is malformed.

The string to sign generator uses this.request.path which is undefined in the new PutObject. So, it literally concats an undefined at the end of the string sent to the custom signing endpoint. You may define a path: '' in PutObject to fix it quickly

[fer90]

Hey there! I know this is SUPER old, but for anyone trying to do the same thing => I applied this changes to the evaporate lib in my project in order to improve performance a little bit and, hopefully, get rid of a sporadic bug in an already deprecated ( 😞 ) MinIO gateway, and I figured the SignatureDoesNotMatch error arises because the string to sign is malformed.

The string to sign generator uses this.request.path which is undefined in the new PutObject. So, it literally concats an undefined at the end of the string sent to the custom signing endpoint. You may define a path: '' in PutObject to fix it quickly

This would fix only AWS Signature V2. There is still an error for AWS Signature V4: As we are not signing the payload, we need to add proper header (x-amz-content-sha256) and value (UNSIGNED-PAYLOAD) as stated here. To fix that, we should add contentSha256: "UNSIGNED-PAYLOAD" in the new request PutObject:

function PutObject(fileUpload, part) {
    this.part = part;

    this.partNumber = 1;
    this.start = 0;
    this.end = fileUpload.sizeBytes;

    var request = {
      method: 'PUT',
      path: '',
      step: 'upload #' + this.partNumber,
      x_amz_headers: fileUpload.xAmzHeadersCommon || fileUpload.xAmzHeadersAtUpload,
      contentSha256: "UNSIGNED-PAYLOAD",
      onProgress: this.onProgress.bind(this)
    };

    SignedS3AWSRequest.call(this, fileUpload, request);
  }