add handling of FileReader errors

[tirnak]

While using the library, it was noticed that error of FileReader is not propagated and just being swallowed. The error can be - problem with permissions, network issues, any kind of IO, basically.

This change propagates the error to the error callback of evaporate.add(...)

[jakubzitny]

Thanks @tirnak, the change makes sense, I'll try to test it, merge and release soon.

Can you please add a test case for such error as well? The test should fail without your change and pass with the change.

[fahadm]

Great catch, I was looking into this too after your PR, and I guess you should use the error handler so that it cleans up properly and prevents it from calling md5 calculation method with null.

Here's a diff (in gist) that might help.

https://gist.github.com/fahadm/d9cbea70d71f0860d04dde1d8d670372

[jakubzitny]

How about adding some tests and submitting another PR @fahadm? 😇

[tirnak]

Test was added. Please, rereview.

[fahadm]

Great test case! I wasn't for the life of me was able to figure out, how to write a proper test case for this case.

@jakubzitny Rather than opening a new PR I would vouch for this PR.

[hhiptmair]

Hi! Any chance to get this merged? :) I think it's a good fix.