Merged
Conversation
This is in preparation for PHP 8.4 support (deprecated implicitly nullable parameters).
Defaulting to null without being nullable (?Foo) is deprecated for typed parameters in PHP 8.4, therefore nullable is now specified explicitly. This change requires at least PHP 7.1 (which has been made a minimum with the parent commit). Additional the call to str_getcsv is adapted to set all optional arguments as the defaults will change in PHP >= 9 and PHP 8.4 deprecated the omission of the optional arguments. Fixes TYPO3#31
Also drop prophecy workarounds since PHP 8.2 compatibility has been enabled upstream.
Member
Author
|
Run in TYPO3 testing infrastructure: https://git.typo3.org/typo3/CI/cms/-/jobs/3846652 |
sbuerk
approved these changes
Oct 9, 2024
helhum
reviewed
Oct 10, 2024
lolli42
approved these changes
Oct 11, 2024
helhum
approved these changes
Oct 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an alternative to #32.
It drops support for PHP <7.1 in order to support PHP 8.4 deprecation free without requiring arguments to be removed or added.
(Changing arguments caused issues in previous changes, because old and new code is mixed during
composer updatewithing one process)