fix(connections): drain password-source command output without a reader race

[datlechin]

Summary

Splits the PasswordSourceResolver change out of #1813 (a MongoDB numeric-literal fix), where it was bundled without a description, test, or CHANGELOG entry.

resolveCommand runs a shell command to fetch a connection password (used by command, 1Password, Vault, and AWS Secrets Manager sources) and reads its stdout/stderr. The old code drained the pipes with readabilityHandler, then set the handlers to nil and called readDataToEndOfFile() after the process exited. Setting a readabilityHandler to nil does not wait for an in-flight handler block, so a handler could append a chunk after readDataToEndOfFile() had already appended the tail. The collector is lock-guarded, so bytes are not corrupted individually, but they can land out of order, which garbles the resolved password.

Change

• Drain stdout and stderr with one blocking read loop per stream on a concurrent DispatchQueue, joined with a DispatchGroup. Each stream has a single reader, so appends stay in order, and the two streams drain in parallel so neither can block the other by filling its pipe buffer.
• Behavior is otherwise unchanged: the 1 MB output cap still throws outputTooLarge (and terminates the process), the 30s timeout still throws commandTimedOut, and a non-zero exit still throws commandFailed with stderr.

Tests

New PasswordSourceResolverTests:

• stdout is returned trimmed
• a large stdout (300 KB) drains in full and in order while stderr is also draining
• a failing command surfaces its exit code and stderr
• output over the 1 MB cap fails as outputTooLarge
• a command past the timeout is terminated and fails as commandTimedOut
• empty output fails as emptyPassword

Notes

• AppKit/subprocess: these tests spawn /bin/bash, which is what the resolver does in production (TablePro ships non-sandboxed with the hardened runtime).
• The MongoDB fix stays in fix(plugin-mongodb): emit only JSON-valid numeric literals #1813, now scoped to just that change.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 86d7dcfc42

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Rename duplicate test suite type

Because TableProTests is a file-system-synchronized target in TablePro.xcodeproj/project.pbxproj, this new file is compiled into the same test module as TableProTests/Core/Utilities/PasswordSourceResolverTests.swift, which already declares struct PasswordSourceResolverTests at line 11. Building the test target will therefore hit an invalid redeclaration; rename this suite or merge these tests into the existing suite.

Useful? React with 👍 / 👎.