Closed
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Batch 5 (final) of anti-pattern fixes. Addresses 20 low-priority cleanup items.
Changes
.cornerRadius()with.clipShape(RoundedRectangle())— 12 occurrences, 8 filesnonisolated deinitfromAppDelegateDispatchQueue.main.asyncwithTaskin@MainActorSQLEditorCoordinator— 4 occurrences@MainActortoUserDefaults+RecentDatabases.trackDatabaseAccessLoggerwarning on invalid hex color fallback inColor+HexAppLanguage.apply()side effectThemeEnginetypography inConnectionSwitcherPopover— replace 4 hardcoded font sizesSkipped (intentional)
Selector("showSettingsWindow:")— standard macOS pattern, no alternativehasInitializedinMainContentView— guards tab restoration beyond coordinator initTask { @MainActor in }inDatabaseSwitcherSheet.moveSelection— needed for SwiftUI warningTest plan
Summary by CodeRabbit
New Features
Bug Fixes
Improvements