fix: connection list mismatch after iCloud sync#517
Merged
Conversation
ConnectionStorage.saveConnections() set cache BEFORE writing to UserDefaults. If encoding failed or a race condition occurred, cache diverged from disk. All consumers (welcome window, dock menu, connection switcher) read stale data. Fix: clear cache AFTER successful write (matching GroupStorage/TagStorage pattern) and invalidate cache before applying remote sync changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #516
Problem
Welcome window shows different connections from the connection menu after iCloud sync. Duplicating a connection makes all connections appear.
Root Cause
ConnectionStorage.saveConnections()setcachedConnections = connectionsBEFORE writing to UserDefaults. If encoding failed or a race occurred, cache diverged from disk. All 11 consumers read stale cache.Fix
GroupStorage/TagStoragepattern)invalidateCache()methodinvalidateCache()before applying remote sync changesTest plan