fix: set UTF-8 client charset for SQL Server connections#528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DBSETCHARSETtoUTF-8on the FreeTDS login record so Unicode data (Thai, CJK, Arabic, emoji, etc.) innvarchar/nchar/ntextcolumns is delivered as UTF-8 instead of being mangled through the server's default single-byte codepagecolumnValueAsStringto try UTF-8 decoding first for nvarchar types (with UTF-16LE fallback), since FreeTDS converts wire data to the client charset but may retain the original type tokenWithout this fix, any characters outside the server's default codepage (e.g., cp1252) appear as
?in TablePro. Reported by a user with Thai text in nvarchar columns on Azure SQL Server.Test plan
nvarcharcolumn containing Thai text (e.g.,N'สวัสดี') — verify it displays correctlyvarcharandnvarcharcolumns still displays correctlynvarcharcolumnsntextcolumns also render Unicode correctly