perf: scope filter animation to mutation site, cache per-table filters#531
Merged
perf: scope filter animation to mutation site, cache per-table filters#531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.animation()towithAnimationat mutation site —.animation(value: filterStateManager.isVisible)on the results section parent caused SwiftUI to re-evaluate the entire view tree 12+ times per frame during the 0.2s transition. NowwithAnimationis called insidetoggle()/show()/close()onFilterStateManager, scoping the animation to only the filter panel transition..animation(value: tab.errorMessage)— error banners should appear instantly, no need for animation on the entire results section.FilterSettingsStorage—loadLastFilters(for:)was decoding JSON from UserDefaults on every table switch. Now cached in memory, invalidated on save/clear.Test plan