perf: skip column width calculation when saved layout exists#532
Merged
perf: skip column width calculation when saved layout exists#532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
calculateOptimalColumnWidth()samples 30 rows per column to estimate width. During column rebuild, this ran for EVERY column even when the user had saved column widths that would immediately overwrite the calculated values.columnLayout.columnWidthsis non-empty, using saved widths directly. For a 50-column table, this eliminates 50 x 30 = 1,500 cell reads on every column rebuild.Test plan