feat: add option to group all connection tabs in one window#546
Merged
feat: add option to group all connection tabs in one window#546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NSWindowStackControllerassertion)Changes
New feature
TabSettings.groupAllConnectionTabs— new boolean setting with Codable backward compatibilityTabbingIdentifierResolver— returns shared"com.TablePro.main"when groupAll is ONAppDelegate+WindowConfig— normalizes all existing windows'tabbingIdentifierwhen groupAll is ON; skipsorderOutfor windows in active tab groups to preventNSWindowStackControllercrashConnectionSwitcherPopover— usesopenNativeTabpath when groupAll is ON instead of forcing separate windowAppDelegate+ConnectionHandler/AppDelegate+FileOpen— skipallowsAutomaticWindowTabbing = falsewhen groupAll is ONBug fixes (apply regardless of groupAll setting)
closeSiblingNativeWindows()now filters byconnectionId— prevents closing other connections' tabs during database switchopenTableTabsibling search now filters by connection ownership — prevents false-positive matches across connections with same table nameopenPreviewTabnow reuses non-preview table tabs with no active work + empty query tabs — prevents orphaned "SQL Query" tabsWelcomeViewModel/ConnectionFormViewconnection failure handlers now close only the failing connection's windows viaWindowLifecycleMonitor, not all main windowsconnectFromDockfailure handler scoped to failing connection's windowsexecuteQueryInternal/applyMultiStatementResultspreservetableNamefor table tabs instead of re-extracting from SQL (fixes title fallback to "SQL Query" when regex fails on schema-qualified identifiers)configureWindowinMainContentViewrespectsgroupAllConnectionTabsfortabbingIdentifierTests
TabbingIdentifierResolver.resolve(groupAllConnections: true)Test plan