fix: always reset isExecuting on query completion to prevent stuck tabs#548
Merged
fix: always reset isExecuting on query completion to prevent stuck tabs#548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isExecuting = falsewas guarded bycapturedGeneration == queryGeneration— when a newer query superseded the current one, the stale query's cleanup was skipped entirely, leavingisExecuting = trueforeverrunQuery()calls silently returned due to theguard !isExecutingcheckChanges
Ensures
isExecuting,currentQueryTask, andtoolbarStateare always reset on every query exit path:MainContentCoordinator.swiftisExecutingbefore returningMainContentCoordinator.swiftisExecutingbefore generation guardMainContentCoordinator.swiftcurrentQueryTask = nil+MultiStatement.swiftbreaktoreturnwith rollback + cleanup (was falling through tocommitTransaction)+MultiStatement.swift+MultiStatement.swiftisExecutingbefore generation guard+MultiStatement.swiftisExecutingbefore generation guardTest plan