refactor: restructure settings for correct data flow and native macOS patterns#549
Merged
refactor: restructure settings for correct data flow and native macOS patterns#549
Conversation
9143267 to
d980715
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@Stateand directAppSettingsStoragecalls, now uses the samedidSet→ persist +SyncChangeTracker.markDirtypattern as all other settings domains@Bindable settingsManagerdependency; now receives@Binding var tabSettingsandonResetAllclosure explicitlySelector(("showSettingsWindow:"))(3 call sites) replaced withEnvironment(\.openSettings)(macOS 14+ public API) andNotificationCenterfor AppKit contextsinit(from decoder:)withdecodeIfPresent+ defaults, matching all other settings structs.onChangeinThemeListViewthat duplicated activation already handled byAppSettingsManager.appearance.didSetTest plan
SyncCoordinatorreceives enable/disable callsxcodebuild— no warnings in changed files