Conversation
Add missing binary for LVGL
📝 WalkthroughWalkthroughAdds SDK integration testing: GitHub Actions workflow gains two post-release steps to prepare and run a test SDK with ESP-IDF v5.5. Updates build scripts to point LVGL binary and licence mappings to new paths. Adds Tests/SdkIntegration with CMake files, a minimal LVGL test app in C, manifest.properties, and a large tactility.py CLI tool implementing SDK download, build, packaging, and HTTP-based run/install/uninstall flows. Updates .gitignore to add .tactility and adjust build-related patterns. Documentation adds a font design token item. 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
Tests/HelloWorld/tactility.py (1)
504-529: Makeskip_buildexplicit to avoid hidden global coupling.
build_action()readsskip_buildat lines 525 and 527, but that variable is only defined in__main__. Importing and callingbuild_action()directly from another module will raiseNameError. Passskip_buildexplicitly as a parameter with a default value.♻️ Suggested refactor
-def build_action(manifest, platform_arg): +def build_action(manifest, platform_arg, skip_build=False): # Environment validation validate_environment() platforms_to_build = get_manifest_target_platforms(manifest, platform_arg) @@ - if not build_action(manifest, platform): + if not build_action(manifest, platform, skip_build): sys.exit(1) @@ - if build_action(manifest, platform): + if build_action(manifest, platform, skip_build): if install_action(sys.argv[2], platforms_to_install): run_action(manifest, sys.argv[2])
Summary by CodeRabbit
New Features
Documentation
Chores