Skip to content

Fix SDK#487

Merged
KenVanHoeylandt merged 11 commits intomainfrom
fix-sdk
Feb 6, 2026
Merged

Fix SDK#487
KenVanHoeylandt merged 11 commits intomainfrom
fix-sdk

Conversation

@KenVanHoeylandt
Copy link
Contributor

@KenVanHoeylandt KenVanHoeylandt commented Feb 6, 2026

Summary by CodeRabbit

  • New Features

    • Added a full SDK integration test suite with a minimal sample app and automated multi-platform build/run flows.
    • Added a new CLI build tool to orchestrate SDK download, build, packaging, and device install/run.
  • Documentation

    • Added typography design token suggestion to ideas.
  • Chores

    • Updated CI to run SDK integration prep and test steps.
    • Adjusted build artifact paths, license mappings, and repository ignore rules (including .tactility).

@coderabbitai
Copy link

coderabbitai bot commented Feb 6, 2026

📝 Walkthrough

Walkthrough

Adds SDK integration testing: GitHub Actions workflow gains two post-release steps to prepare and run a test SDK with ESP-IDF v5.5. Updates build scripts to point LVGL binary and licence mappings to new paths. Adds Tests/SdkIntegration with CMake files, a minimal LVGL test app in C, manifest.properties, and a large tactility.py CLI tool implementing SDK download, build, packaging, and HTTP-based run/install/uninstall flows. Updates .gitignore to add .tactility and adjust build-related patterns. Documentation adds a font design token item.

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'Fix SDK' is vague and generic, providing no meaningful information about the specific changes made. Replace with a more descriptive title that conveys the main change, such as 'Add SDK integration testing framework' or 'Refactor SDK build and release process'.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-sdk

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 6

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
Tests/HelloWorld/tactility.py (1)

504-529: Make skip_build explicit to avoid hidden global coupling.

build_action() reads skip_build at lines 525 and 527, but that variable is only defined in __main__. Importing and calling build_action() directly from another module will raise NameError. Pass skip_build explicitly as a parameter with a default value.

♻️ Suggested refactor
-def build_action(manifest, platform_arg):
+def build_action(manifest, platform_arg, skip_build=False):
     # Environment validation
     validate_environment()
     platforms_to_build = get_manifest_target_platforms(manifest, platform_arg)
@@
-        if not build_action(manifest, platform):
+        if not build_action(manifest, platform, skip_build):
             sys.exit(1)
@@
-        if build_action(manifest, platform):
+        if build_action(manifest, platform, skip_build):
             if install_action(sys.argv[2], platforms_to_install):
                 run_action(manifest, sys.argv[2])

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

@KenVanHoeylandt KenVanHoeylandt merged commit 0042ce6 into main Feb 6, 2026
8 of 52 checks passed
@KenVanHoeylandt KenVanHoeylandt deleted the fix-sdk branch February 6, 2026 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant