Fixes deadlock at kill_cmd and execute_cmd#11
Open
esauvisky wants to merge 1 commit intoTamerPlatform:masterfrom
Open
Fixes deadlock at kill_cmd and execute_cmd#11esauvisky wants to merge 1 commit intoTamerPlatform:masterfrom
esauvisky wants to merge 1 commit intoTamerPlatform:masterfrom
Conversation
I don't know the particular reason in which the old command wasn't working, but it was deadlocking on the `Popen(kill_cmd)` line. Even spawning the command on a `adb shell` did not work. If I'd to guess, maybe something related to newer devices, SDK versions, etc.? Notwithstanding, it seems to me that the proposed implementation is more robust, at least based on the little knowledge I have :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know the particular reason in which the old command wasn't working, but it was deadlocking on the
Popen(kill_cmd)line. Even spawning the command on aadb shelldid not work. If I'd to guess, maybe something related to newer devices, SDK versions, etc.?Notwithstanding, it seems to me that the proposed implementation is more robust, at least based on the little knowledge I have :)