Skip to content

fix: fix go to source file whose path contains $ symbol #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
knthmn wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: fix go to source file whose path contains $ symbol #450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9522777
fix: fix go to source when file name contains $ symbol
knthmn May 22, 2026
48334ec
chore: add changeset
knthmn May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/floppy-mammals-write.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@tanstack/devtools-vite': patch
---

fix go to source file whose path contains $ symbol
2 changes: 1 addition & 1 deletion packages/devtools-vite/src/editor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export const DEFAULT_EDITOR_CONFIG: EditorConfig = {
open: async (path, lineNumber, columnNumber) => {
const launch = (await import('launch-editor')).default
launch(
`${path.replaceAll('$', '\\$')}${lineNumber ? `:${lineNumber}` : ''}${columnNumber ? `:${columnNumber}` : ''}`,
`${path}${lineNumber ? `:${lineNumber}` : ''}${columnNumber ? `:${columnNumber}` : ''}`,
undefined,
(filename, err) => {
console.warn(`Failed to open ${filename} in editor: ${err}`)
Expand Down