fix(angular-query): refresh injectQueries results after query list changes#10709
Open
raashish1601 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8704.
When the
injectQueriesquery list changes after subscriber results exist, the subscriber result can mask the new optimistic result. This clears the subscriber snapshot whenever the observer query set is updated, allowing the latest query list to be reflected immediately.Validation
corepack pnpm exec vitest run src/__tests__/inject-queries.test.tsfrompackages/angular-query-experimental(5 tests pass)git diff --check origin/main...HEADWindows checkout limitations:
corepack pnpm test:eslintfails before checking this change because tracked config symlinks are materialized as plain text in this checkout (core.symlinks=false), and Windows denied creating real symlinks.corepack pnpm test:types:tscurrentfails on those same materialized symlink config files.corepack pnpm --filter @tanstack/query-core buildfails for the sameroot.tsup.config.jssymlink materialization, so the Angular package build cannot be completed locally here.