Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/palette.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2025-04-16 - App Bar and Drawer icon buttons lacked ARIA labels
**Learning:** The custom App Bar and DrawerMenu had icon-only buttons for back, menu, and close, which were missing accessibilityLabel properties, making them hard to use for screen reader users.
**Action:** Add accessibilityLabel along with accessible={true} and accessibilityRole="button" for all icon-only buttons to ensure they are screen-reader accessible.
4 changes: 2 additions & 2 deletions App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -193,11 +193,11 @@ function AppInner() {
>
<View style={[StyleSheet.absoluteFill, { backgroundColor: colors.appBar }]} />
{overlay ? (
<TouchableOpacity onPress={handleBack} style={styles.iconBtn}>
<TouchableOpacity onPress={handleBack} style={styles.iconBtn} accessible={true} accessibilityRole="button" accessibilityLabel={t("back")}>
<MaterialIcons name="arrow-back" size={22} color={colors.primaryDark} />
</TouchableOpacity>
) : (
<TouchableOpacity onPress={() => setDrawerOpen(true)} style={styles.iconBtn}>
<TouchableOpacity onPress={() => setDrawerOpen(true)} style={styles.iconBtn} accessible={true} accessibilityRole="button" accessibilityLabel={t("menu")}>
<MaterialIcons name="menu" size={24} color={colors.primaryDark} />
</TouchableOpacity>
)}
Expand Down
2 changes: 1 addition & 1 deletion src/components/DrawerMenu.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ export default function DrawerMenu({ visible, onClose, onSelect }: Props) {
style={styles.headerGradient}
>
<AeroStaffLogo variant="large" monochrome />
<TouchableOpacity onPress={onClose} style={styles.closeIconBtn}>
<TouchableOpacity onPress={onClose} style={styles.closeIconBtn} accessible={true} accessibilityRole="button" accessibilityLabel={t("close")}>
<MaterialIcons name="close" size={20} color="rgba(255,255,255,0.7)" />
</TouchableOpacity>
</LinearGradient>
Expand Down
4 changes: 2 additions & 2 deletions src/i18n/translations.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const it = {
overlayManuals: 'Manuali DCS', overlaySettings: 'Impostazioni',
// Common
cancel: 'Annulla', save: 'Salva', delete: 'Elimina', error: 'Errore',
confirm: 'Conferma', ok: 'OK', add: 'Aggiungi',
confirm: 'Conferma', ok: 'OK', add: 'Aggiungi', back: 'Indietro', close: 'Chiudi', menu: 'Menu',
// Settings
settingsTitle: 'Impostazioni',
sectionTheme: 'TEMA',
Expand Down Expand Up @@ -165,7 +165,7 @@ const en: typeof it = {
overlayManuals: 'DCS Manuals', overlaySettings: 'Settings',
// Common
cancel: 'Cancel', save: 'Save', delete: 'Delete', error: 'Error',
confirm: 'Confirm', ok: 'OK', add: 'Add',
confirm: 'Confirm', ok: 'OK', add: 'Add', back: 'Back', close: 'Close', menu: 'Menu',
// Settings
settingsTitle: 'Settings',
sectionTheme: 'THEME',
Expand Down
Loading