🎨 Palette: Improve accessibility and placeholder text in NotepadScreen#110
🎨 Palette: Improve accessibility and placeholder text in NotepadScreen#110TargetMisser wants to merge 1 commit intomainfrom
Conversation
- Added accessibility label and role to the clear note icon button - Added disabled accessibility state to the save button - Extracted the Italian notepad placeholder and translated it using i18n - Journaled the a11y findings Co-authored-by: TargetMisser <52361977+TargetMisser@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 participant
💡 What:
accessible,accessibilityRole,accessibilityLabel) to the icon-only Clear button in the Notepad screen.accessibilityState={{ disabled: saved }}to the Save button to communicate its dimmed/disabled state to screen readers.t()hook for better internationalization support.🎯 Why:
Screen readers previously announced the icon-only "Clear" button simply as "button" or "clickable", which lacks context. Adding labels makes the app more usable for visually impaired users. Furthermore, extracting the placeholder text to translations ensures non-Italian speakers get the correct helper text when creating notes.
📸 Before/After:
Visuals are identical, but VoiceOver/TalkBack will now accurately announce "Clear notes" instead of "Button". The placeholder text translates appropriately based on the device locale.
♿ Accessibility:
accessibilityRole="button"addedaccessibilityLabel={t('notepadClearTitle')}addedaccessibilityState={{ disabled: saved }}addedPR created automatically by Jules for task 734165834398953703 started by @TargetMisser