🎨 Palette: Add accessibility labels to password visibility toggles#114
🎨 Palette: Add accessibility labels to password visibility toggles#114TargetMisser wants to merge 1 commit intomainfrom
Conversation
Co-authored-by: TargetMisser <52361977+TargetMisser@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
💡 What:
Added screen reader accessibility props (
accessible,accessibilityRole, andaccessibilityLabel) to the icon-only<TouchableOpacity>buttons that toggle password visibility in thePasswordScreen.🎯 Why:
Previously, screen readers could not infer the purpose of the eye icon buttons, making it impossible for visually impaired users to understand what the buttons did or their current state. This small enhancement improves the accessibility of the password manager without altering its visual layout.
📸 Before/After:
<TouchableOpacity onPress={...}> <MaterialIcons name="visibility" .../> </TouchableOpacity>(Screen reader announces "Button" with no context).<TouchableOpacity onPress={...} accessible accessibilityRole="button" accessibilityLabel={revealed ? t('passwordHide') : t('passwordShow')}> ... </TouchableOpacity>(Screen reader announces "Show password, button" or "Hide password, button").♿ Accessibility:
passwordShowandpasswordHidestrings to theitandentranslation dictionaries.accessibilityLabelbased on the current toggle state.accessibilityRole="button"..jules/palette.mdfor future reference.PR created automatically by Jules for task 5106159632502781506 started by @TargetMisser