Skip to content

🎨 Palette: Add accessibility labels to password visibility toggles#114

Open
TargetMisser wants to merge 1 commit intomainfrom
palette/a11y-password-visibility-toggle-5106159632502781506
Open

🎨 Palette: Add accessibility labels to password visibility toggles#114
TargetMisser wants to merge 1 commit intomainfrom
palette/a11y-password-visibility-toggle-5106159632502781506

Conversation

@TargetMisser
Copy link
Copy Markdown
Owner

💡 What:
Added screen reader accessibility props (accessible, accessibilityRole, and accessibilityLabel) to the icon-only <TouchableOpacity> buttons that toggle password visibility in the PasswordScreen.

🎯 Why:
Previously, screen readers could not infer the purpose of the eye icon buttons, making it impossible for visually impaired users to understand what the buttons did or their current state. This small enhancement improves the accessibility of the password manager without altering its visual layout.

📸 Before/After:

  • Before: <TouchableOpacity onPress={...}> <MaterialIcons name="visibility" .../> </TouchableOpacity> (Screen reader announces "Button" with no context).
  • After: <TouchableOpacity onPress={...} accessible accessibilityRole="button" accessibilityLabel={revealed ? t('passwordHide') : t('passwordShow')}> ... </TouchableOpacity> (Screen reader announces "Show password, button" or "Hide password, button").

Accessibility:

  • Added passwordShow and passwordHide strings to the it and en translation dictionaries.
  • Applied dynamic accessibilityLabel based on the current toggle state.
  • Applied accessibilityRole="button".
  • Journaled the pattern in .jules/palette.md for future reference.

PR created automatically by Jules for task 5106159632502781506 started by @TargetMisser

Co-authored-by: TargetMisser <52361977+TargetMisser@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flight-work-app Ready Ready Preview, Comment, Open in v0 Apr 20, 2026 1:51am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant