🛡️ Sentinel: [HIGH] Fix insecure password storage in AsyncStorage#119
🛡️ Sentinel: [HIGH] Fix insecure password storage in AsyncStorage#119TargetMisser wants to merge 1 commit intomainfrom
Conversation
Migrated password storage to use SecureStore for sensitive fields while keeping metadata in AsyncStorage to bypass Android size limits. Existing plain text passwords are automatically migrated. Co-authored-by: TargetMisser <52361977+TargetMisser@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 participant
🚨 Severity: HIGH
💡 Vulnerability: User passwords were saved in plain text in
AsyncStorage, an unencrypted storage mechanism. This occurred as a naive workaround becauseSecureStorehas a 2048-byte limit on Android, failing to store large JSON arrays of passwords.🎯 Impact: Anyone with physical access to an unlocked device or another app with sufficient permissions could extract plain text passwords.
🔧 Fix: Implemented a hybrid storage pattern: lists of metadata are stored in
AsyncStoragewith secrets masked (e.g.,password: '***'), and the actual secrets are stored individually inSecureStoreusing row-specific dynamic keys (e.g.,aerostaff_pwd_${id}). Legacy plain text data is automatically migrated on mount.✅ Verification: Ensure tests pass (
npm run typecheckandnpx jest --passWithNoTests).PR created automatically by Jules for task 18270886959965303458 started by @TargetMisser