🛡️ Sentinel: [CRITICAL] Fix insecure password storage#97
🛡️ Sentinel: [CRITICAL] Fix insecure password storage#97TargetMisser wants to merge 1 commit intomainfrom
Conversation
- Migrated plain-text password storage from AsyncStorage to a hybrid pattern.
- AsyncStorage now stores '***' as a masked password for metadata rendering.
- The actual sensitive passwords are now stored in SecureStore using row-specific dynamic keys (`aerostaff_pwd_${id}`).
- Added error handling when reading/writing to SecureStore.
Co-authored-by: TargetMisser <52361977+TargetMisser@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 participant
🚨 Severity: CRITICAL
💡 Vulnerability: User passwords were saved to AsyncStorage in plain text, making them susceptible to exposure on rooted/jailbroken devices or via app backup extraction.
🎯 Impact: Attackers or malicious apps could access plain text passwords from user devices.
🔧 Fix: Implemented a hybrid storage pattern. Metadata list is stored in AsyncStorage with passwords masked as '***'. The actual secrets are stored individually in SecureStore using row-specific keys. The
useEffecthook now performs migration of old passwords securely on mount. Added try-catch blocks to all SecureStore async calls for resilience.✅ Verification: Ran
npm run typecheckand verified code changes. Tested using Jest.PR created automatically by Jules for task 16315899139366720794 started by @TargetMisser