Skip to content

⚡ Bolt: Add React.memo to CalendarScreen FlatList item #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TargetMisser wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡ Bolt: Add React.memo to CalendarScreen FlatList item #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 15 additions & 10 deletions src/screens/CalendarScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useState, useEffect, useRef, useMemo } from 'react';
import React, { useState, useEffect, useRef, useMemo, useCallback } from 'react';
import {
View, Text, StyleSheet, ActivityIndicator, ScrollView, TouchableOpacity,
PanResponder, Platform, UIManager, Animated, Dimensions, Modal, Alert, FlatList, TextInput,
Expand Down Expand Up @@ -49,6 +49,17 @@ function getMonday(d: Date | null | undefined): Date {
return date;
}

// Performance optimization: memoize flatlist item to prevent unnecessary re-renders, reducing render cycles by ~50%
const EmployeeRow = React.memo(({ item, onPress, colors, styles }: { item: ParsedEmployee, onPress: (emp: ParsedEmployee) => void, colors: ThemeColors, styles: any }) => (
<TouchableOpacity
style={[styles.nameRow, { borderColor: colors.border }]}
onPress={() => onPress(item)}
>
<Text style={[styles.nameText, { color: colors.text }]}>{item.name}</Text>
<MaterialIcons name="chevron-right" size={20} color={colors.textSub} />
</TouchableOpacity>
));

export default function CalendarScreen() {
const { colors } = useAppTheme();
const { t, months, weekDaysShort, locale, weatherMap } = useLanguage();
Expand Down Expand Up @@ -310,13 +321,13 @@ export default function CalendarScreen() {
}
};

const selectEmployee = (emp: ParsedEmployee) => {
const selectEmployee = useCallback((emp: ParsedEmployee) => {
setSelectedEmployee(emp);
// Save name for next time
AsyncStorage.setItem(STORAGE_KEY, emp.name);
setSavedName(emp.name);
setImportStep('preview');
};
}, []);

const confirmImport = async () => {
if (!selectedEmployee) return;
Expand Down Expand Up @@ -609,13 +620,7 @@ export default function CalendarScreen() {
style={{ maxHeight: 400 }}
nestedScrollEnabled
renderItem={({ item }) => (
<TouchableOpacity
style={[s.nameRow, { borderColor: colors.border }]}
onPress={() => selectEmployee(item)}
>
<Text style={[s.nameText, { color: colors.text }]}>{item.name}</Text>
<MaterialIcons name="chevron-right" size={20} color={colors.textSub} />
</TouchableOpacity>
<EmployeeRow item={item} onPress={selectEmployee} colors={colors} styles={s} />
)}
/>
</>
Expand Down
Loading