Skip to content

fix(v2-inspector): make 'Talk to' gate runtime-based, not name-hardcoded #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
samxu01 wants to merge 1 commit into from
Closed

fix(v2-inspector): make 'Talk to' gate runtime-based, not name-hardcoded #300

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions frontend/src/v2/components/V2PodInspector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,25 @@ interface V2PodInspectorProps {
onOpenInvite?: () => void;
}

// Only openclaw-runtime agents can hold a real DM session — they have a chat
// runtime that responds. commonly-bot is the internal Tier 1 summarizer (no
// chat runtime); pod-summarizer is Tier 1 native (also no DM).
const isAgentDmable = (agent: { name?: string; agentName?: string }): boolean => {
const n = agent.name || agent.agentName;
return n === 'openclaw';
// Any agent with a real chat runtime can hold a DM session. The Tier 1
// internal services (commonly-bot summarizer, pod-summarizer) don't have a
// runtime that responds to chat — they're cron / event-driven only.
//
// Previously this was hardcoded to `agent.name === 'openclaw'`, which
// silently excluded every other runtime — Claude Code wrappers, Codex
// wrappers, stub adapters, webhook bots, native runtime agents. Anyone
// installing an agent via `commonly agent attach <claude|codex|...>`
// got an agent that worked end-to-end EXCEPT that the inspector's
// "Talk to" button never appeared.
//
// Gate now reads from the resolved runtime: any non-internal runtime
// is dmable. Falls back to `false` for unknown payload shapes.
const isAgentDmable = (agent: { runtime?: { runtimeType?: string } | null }): boolean => {
const t = agent?.runtime?.runtimeType;
if (!t) return false;
// Tier 1 native services — no chat runtime, no DM target.
if (t === 'internal') return false;
return true;
};

interface AgentTaskMap {
Expand Down
Loading