Implement Redis-based data ingestion service with event handlers and Synapse integration#153
Implement Redis-based data ingestion service with event handlers and Synapse integration#153Patrik-Corri wants to merge 21 commits intodevfrom
Conversation
This reverts commit c60e326.
… into patrik_corri-dev
|
|
||
| # SINGLE atomic install | ||
| RUN npm config set fetch-retries 5 \ | ||
| && npm config set fetch-retry-mintimeout 20000 \ |
There was a problem hiding this comment.
Why were these taken out for each service in the Dockerfiles?
| RUN chmod +x /usr/local/bin/load-k8s-env.sh /usr/local/bin/docker-entrypoint.sh | ||
| COPY --chown=root:root platform-services/shared/scripts/load-k8s-env.sh /usr/local/bin/load-k8s-env.sh | ||
| COPY --chown=root:root platform-services/shared/scripts/docker-entrypoint.sh /usr/local/bin/docker-entrypoint.sh | ||
| RUN sed -i 's/\r$//' /usr/local/bin/load-k8s-env.sh /usr/local/bin/docker-entrypoint.sh && \ |
There was a problem hiding this comment.
Are you having linux build issues?
| "agi-decisions", | ||
| "training-events" | ||
| "training-events", | ||
| "ingestion-events", |
There was a problem hiding this comment.
So you just set up the channel, but how does this ingest data?
There was a problem hiding this comment.
All I see are dockerfile edits, small changes to references and the streaming client for the shared utils, which then is imported by the lang intelligence service which then creates client subscriptions to the channels, ensure that they match up.
@thatsnotrlght you need to be making some progress on the Redis stuff by now in order for @Patrik-Corri to start receiving data
There was a problem hiding this comment.
Any dockerfile edits are because i cannot build the containers without those changes, so ignore those. The data ingestion files are all located in the language-intellegence-service submodule.
a98efcf
Every other file change can be ignored as they are only to help me build the docker containers.
You said i have to create a PR for both the submodule and platform correct?
There was a problem hiding this comment.
Why is it that you are not able to build the containers? Do not put the sed command into the Dockerfile, you need to restore those changes and manually run the sed command on those files, then commit that state of the files. That will resolve the issues for everyone taking out those invisible windows chars, as well as it won't edit the Dockerfile. 2 birds with 1 stone.
You need to create a PR for both the submodule changes and the platform's submodule pointer as well as any platform file changes.
|
@SeanSan06 Going to assign this one to you this week, there's another PR in language-intelligence-service related to it (#23). Plaky task associated with this is titled "Data Ingestion Service Integration - Integrate with API Gateway and Synapse", be sure to assign yourself as the engineer there and post your review comment on the task as well. If you need any help, let me know! |
|
@SeanSan06 @austinm2h35-sketch is busy helping me this week, give this to someone else. We had 3 more QAs join, we need to get them going and utilize them. Todd and Jeremy Chaves need help. @Todd838 @JC5467 |
…ckerfiles Normalize load-k8s-env.sh, docker-entrypoint.sh, prisma-baseline.sh (and ops/k8s copies) to Unix LF. Drop RUN sed CRLF fixes from service Dockerfiles; chmod-only after COPY. Add .gitattributes eol=lf for shared/scripts and ops/k8s *.sh. Made-with: Cursor
…utes Made-with: Cursor
…RLF sed removed) Made-with: Cursor
|
@thatsnotrlght and you are working together on this right |
|
@JC5467 Checking in on this, if you're stuck just reach out and I'll get you some help |
|
@Yoloholoknow I'm going to have you take over this testing, if you could. I'll tag you in the related one as well. If you need help just let me know. Thanks! |
|
@Patrik-Corri please resolve the conflicts before me and the team start reviewing and testing |
|
@Patrik-Corri use ai-conflict.py brother |
IMPORTANT:
Description
Briefly explain what this PR does and why.
Include:
Changes
Related
Testing
Important Notes (Optional)
Workflow Checklist (Required)
Review Requests
@Team-Deepiri/support-team