Skip to content

[Refactor] Sort uploaded images by descending date in ImageS3Processor#104

Merged
LeeHanEum merged 1 commit intodevelopfrom
refactor/descending-bydate
Feb 12, 2026
Merged

[Refactor] Sort uploaded images by descending date in ImageS3Processor#104
LeeHanEum merged 1 commit intodevelopfrom
refactor/descending-bydate

Conversation

@LeeHanEum
Copy link
Collaborator

@LeeHanEum LeeHanEum commented Feb 12, 2026

🌱 관련 이슈

📌 작업 내용 및 특이 사항

  • 벚꽃길 이미지 정렬 순서를 사전순에서 최신순으로 변경

📝 참고

📌 체크 리스트

  • 리뷰어를 추가하셨나요 ?
  • 변경사항에 대해 충분히 설명하고 있나요 ?

Summary by CodeRabbit

  • Bug Fixes
    • Image results from S3 are now consistently ordered by upload timestamp in descending order, ensuring deterministic and predictable ordering of returned items.

@LeeHanEum LeeHanEum requested a review from char-yb February 12, 2026 15:05
@LeeHanEum LeeHanEum self-assigned this Feb 12, 2026
@LeeHanEum LeeHanEum linked an issue Feb 12, 2026 that may be closed by this pull request
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 12, 2026

📝 Walkthrough

Walkthrough

A function in the AWS S3 image processor now sorts image results by upload timestamp in descending order, ensuring newly uploaded images appear first in the results.

Changes

Cohort / File(s) Summary
Image Sorting Enhancement
pida-clients/aws-client/src/main/kotlin/com/pida/client/aws/image/ImageS3Processor.kt
Modified listPresignedGets to sort S3 image results by uploadedAt timestamp in descending order, replacing unsorted list collection with ordered results.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Hop skip, sort and bounce with glee,
Latest images now dance so free,
No more alphabets, just timestamps bright,
Newest first—what a delightful sight!

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed The pull request implements the requirement from issue #103 by sorting 벚꽃길 images by descending date instead of lexicographical order.
Out of Scope Changes check ✅ Passed All changes in the pull request are directly related to implementing the sorting requirement specified in issue #103; no out-of-scope modifications detected.
Title check ✅ Passed The pull request title accurately describes the main change: sorting uploaded images by descending date in the ImageS3Processor component, which directly matches the code modification that adds sorting by uploadedAt in descending order.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch refactor/descending-bydate

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@LeeHanEum LeeHanEum changed the title refactor: Sort uploaded images by descending date in ImageS3Processor [Refactor] Sort uploaded images by descending date in ImageS3Processor Feb 12, 2026
@LeeHanEum LeeHanEum merged commit f0dc8a9 into develop Feb 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

♻️ 벚꽃길 이미지 최신순 정렬로 변경

1 participant