Skip to content

[Fix] Add place search endpoint to enable anonymous api call#91

Merged
LeeHanEum merged 2 commits intodevelopfrom
fix/place-search-anonymous
Feb 1, 2026
Merged

[Fix] Add place search endpoint to enable anonymous api call#91
LeeHanEum merged 2 commits intodevelopfrom
fix/place-search-anonymous

Conversation

@LeeHanEum
Copy link
Collaborator

@LeeHanEum LeeHanEum commented Feb 1, 2026

🌱 관련 이슈

📌 작업 내용 및 특이 사항

  • TransactionalEventListener 로 인한 이벤트 유실 문제 해결
  • 비로그인 사용자가 검색 기능 사용할 수 있게 허용

📝 참고

📌 체크 리스트

  • 리뷰어를 추가하셨나요 ?
  • 변경사항에 대해 충분히 설명하고 있나요 ?

Summary by CodeRabbit

  • New Features

    • Places search API endpoint is now accessible without authentication
  • Chores

    • Updated search history event handling mechanism

✏️ Tip: You can customize this high-level summary in your review settings.

@LeeHanEum LeeHanEum requested a review from char-yb February 1, 2026 10:20
@LeeHanEum LeeHanEum self-assigned this Feb 1, 2026
@LeeHanEum LeeHanEum linked an issue Feb 1, 2026 that may be closed by this pull request
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 1, 2026

📝 Walkthrough

Walkthrough

The pull request adds unauthenticated access to the places search API endpoint and modifies the search history event listener to use standard event listening instead of transactional event listening, removing the AFTER_COMMIT phase constraint.

Changes

Cohort / File(s) Summary
Security Configuration
pida-core/core-api/src/main/kotlin/com/pida/config/SecurityConfig.kt
Added "/api/v1/places/search" to permitAll list, granting unauthenticated access to the places search endpoint.
Event Handling
pida-core/core-domain/src/main/kotlin/com/pida/history/SearchHistoryService.kt
Replaced @TransactionalEventListener with @EventListener on handleSearchEvent method, removing AFTER_COMMIT phase constraint and transactional event listener dependency.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A hop and a bound, permissions now found,
The places we search are no longer bound,
Events flow free without transactional chains,
Simple and swift through the open plains! 🌿

🚥 Pre-merge checks | ✅ 3 | ❌ 2
❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The SearchHistoryService change (replacing TransactionalEventListener with EventListener) appears to address event loss but is not mentioned in the PR objectives or linked issue scope. Clarify whether the SearchHistoryService change is part of issue #90 or if it should be in a separate PR to maintain focused scope.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title clearly describes the main change: adding the place search endpoint to permitAll list for anonymous API access.
Linked Issues check ✅ Passed The PR addresses the linked issue #90 by enabling anonymous access to the place search API through security configuration changes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/place-search-anonymous

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@LeeHanEum LeeHanEum merged commit 73a7688 into develop Feb 1, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 장소 검색 API 권한 처리

1 participant