Skip to content

[FIX] 오늘/집중 탭 변경 후 통계 캐시 갱신 #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jjangminii merged 1 commit into from
Jul 17, 2026
Merged

[FIX] 오늘/집중 탭 변경 후 통계 캐시 갱신 #266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...app/[locale]/(main)/(with-time-sidebar)/today/_hooks/todo-modal/use-create-todo-submit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import type { CreateTodoRequest } from "@/schemas/todo/todo-schema";

import { getGetTodayQueryKey } from "@/api/generated/endpoints/home/home";
import { useCreateTodo } from "@/api/generated/endpoints/todo/todo";
import { useStatisticsQueryInvalidation } from "@/hooks/statistics/use-statistics-query-invalidation";

const buildCreateTodoRequestBody = (
data: CreateTodoRequest,
Expand All @@ -29,13 +30,15 @@ export const useCreateTodoSubmit = () => {
const [isErrorToastOpen, setIsErrorToastOpen] = useState(false);
const { mutate: createTodo } = useCreateTodo();
const queryClient = useQueryClient();
const { invalidateStatistics } = useStatisticsQueryInvalidation();

const handleSubmit = (data: CreateTodoRequest) => {
createTodo(
{ data: buildCreateTodoRequestBody(data) },
{
onSuccess: () => {
queryClient.invalidateQueries({ queryKey: getGetTodayQueryKey() });
invalidateStatistics();
},
onError: () => {
setIsErrorToastOpen(true);
Expand Down
3 changes: 3 additions & 0 deletions apps/timo-web/app/[locale]/(main)/(with-time-sidebar)/today/_hooks/useTodayTodoList.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ export const useTodayTodoList = (
invalidateTimeBoxes,
invalidateTodayView,
invalidateFocusTodo,
invalidateStatistics,
} = useTimerQueryInvalidation();

const { mutate: startTimer, isPending: isStartTimerPending } = useStartTimer({
Expand Down Expand Up @@ -119,6 +120,7 @@ export const useTodayTodoList = (
invalidateTimeBoxes();
invalidateTodoDetail(todoId, dateKey);
invalidateFocusTodo();
invalidateStatistics();
},
onError: (error: ErrorType<ErrorDto>) => {
setTodos(previous);
Expand Down Expand Up @@ -149,6 +151,7 @@ export const useTodayTodoList = (
invalidateTodayView();
invalidateTodoDetail(todoId, dateKey);
invalidateFocusTodo();
invalidateStatistics();

@coderabbitai coderabbitai Bot Jul 16, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

타이머 중지 성공 직후에도 통계를 무효화해야 합니다.

현재 invalidateStatistics()가 changeTodoStatus.onSuccess 내부에만 있어, stopTimer는 성공했지만 후속 투두 완료 상태 변경이 실패하면 통계 캐시가 갱신되지 않습니다. stopTimer.onSuccess에서 즉시 한 번 호출하고, 투두 상태 변경 성공 후에도 현재 호출을 유지해 두 mutation의 성공 결과를 모두 반영하세요.

포커스 훅의 stopTimer 성공 처리처럼 타이머 mutation 성공 지점에 직접 배치하는 방식이 안전합니다. TanStack Query도 mutation 성공 시 관련 query를 invalidate하는 패턴을 안내합니다. (tanstack.com)

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@apps/timo-web/app/`[locale]/(main)/(with-time-sidebar)/today/_hooks/useTodayTodoList.ts
at line 154, Update the stopTimer mutation’s onSuccess handler in
useTodayTodoList so it immediately calls invalidateStatistics() after the timer
stops successfully, while retaining the existing call in
changeTodoStatus.onSuccess to reflect later todo-status updates as well.

},
},
);
Expand Down
4 changes: 4 additions & 0 deletions apps/timo-web/app/[locale]/(main)/focus/_hooks/use-focus-session.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ export const useFocusSession = ({
invalidateTimeBoxes,
invalidateTodayView,
invalidateFocusTodo,
invalidateStatistics,
} = useTimerQueryInvalidation();
const invalidateTodoDetail = () => {
const todo = focusView.todo;
Expand Down Expand Up @@ -96,6 +97,7 @@ export const useFocusSession = ({
invalidateTimeBoxes();
invalidateTodayView();
invalidateTodoDetail();
invalidateStatistics();
},
onError: onMutationError,
},
Expand All @@ -110,6 +112,7 @@ export const useFocusSession = ({
invalidateTimeBoxes();
invalidateTodayView();
invalidateTodoDetail();
invalidateStatistics();
},
onError: onMutationError,
},
Expand All @@ -121,6 +124,7 @@ export const useFocusSession = ({
invalidateTimeBoxes();
invalidateTodayView();
invalidateTodoDetail();
invalidateStatistics();
},
onError: onMutationError,
},
Expand Down
Loading