chore(L10n): Add mn-MN translation. (Cyrillic Mongolian) by b114514 · Pull Request #393 · TeamFlos/phira

b114514 · 2024-08-28T17:53:20Z

No description provided.

Copilot

Pull request overview

Adds a new mn-MN (Mongolian) locale across the prpr and phira applications and registers it in the shared l10n language list.

Changes:

Added mn-MN Fluent (.ftl) translation files for prpr UI/game/parser strings.
Added mn-MN Fluent (.ftl) translation files for phira scenes (home, song, multiplayer, settings, etc.).
Registered mn-MN (“Монгол”) in prpr-l10n’s supported language list.

Reviewed changes

Copilot reviewed 27 out of 29 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
prpr/locales/mn-MN/scene.ftl	Adds mn-MN strings for scene/input UI.
prpr/locales/mn-MN/parser.ftl	Adds mn-MN strings for chart/parser errors.
prpr/locales/mn-MN/game.ftl	Adds mn-MN strings for in-game offset/speed UI.
prpr/locales/mn-MN/ending.ftl	Adds mn-MN strings for results/upload UI.
prpr/locales/mn-MN/dialog.ftl	Adds mn-MN strings for dialog UI.
prpr/locales/mn-MN/chart_info.ftl	Adds mn-MN strings for chart metadata editor UI.
prpr-l10n/src/lib.rs	Registers `mn-MN` in the language list.
phira/locales/mn-MN/tags.ftl	Adds mn-MN strings for tag filtering/editing UI.
phira/locales/mn-MN/song.ftl	Adds mn-MN strings for song page, download, edit, review, mods.
phira/locales/mn-MN/settings.ftl	Adds mn-MN strings for settings UI and about text.
phira/locales/mn-MN/respack.ftl	Adds mn-MN strings for skin/resource pack UI.
phira/locales/mn-MN/resource.ftl	Adds mn-MN strings for story/resource chapter text.
phira/locales/mn-MN/rate.ftl	Adds mn-MN strings for rating filter UI.
phira/locales/mn-MN/profile.ftl	Adds mn-MN strings for profile/account actions.
phira/locales/mn-MN/multiplayer.ftl	Adds mn-MN strings for multiplayer UI and messages.
phira/locales/mn-MN/message.ftl	Adds mn-MN strings for in-app messages UI.
phira/locales/mn-MN/login.ftl	Adds mn-MN strings for login/registration UI.
phira/locales/mn-MN/local.ftl	Adds mn-MN strings for local/import status UI.
phira/locales/mn-MN/library.ftl	Adds mn-MN strings for chart library UI.
phira/locales/mn-MN/import.ftl	Adds mn-MN strings for import flow UI.
phira/locales/mn-MN/home.ftl	Adds mn-MN strings for home screen and update UI.
phira/locales/mn-MN/favorites.ftl	Adds an (currently empty) mn-MN favorites locale file.
phira/locales/mn-MN/event.ftl	Adds mn-MN strings for events UI.
phira/locales/mn-MN/common.ftl	Adds mn-MN strings for common actions, TOS/policy UI.
phira/locales/mn-MN/collection.ftl	Adds mn-MN strings for collections UI.
phira/locales/mn-MN/charts_view.ftl	Adds an (currently empty) mn-MN charts view locale file.
phira/locales/mn-MN/chart_order.ftl	Adds mn-MN strings for chart ordering labels.
phira/locales/mn-MN/chapter.ftl	Adds mn-MN strings for chapter difficulty labels.
phira/locales/mn-MN/cali.ftl	Adds mn-MN strings for calibration UI.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-08T17:18:37Z

prpr/locales/mn-MN/parser.ftl

+shader-load-failed = { $path }-аас4 шейдер ачаалахад амжилтгүй боллоо
+shader-not-found = Урьдчилан тохируулсан шейдер олдсонгүй { $shader }
+effect-location = Идэвхтэй байна #{ $id }
+video-load-failed = { $path }-аас4 видео уншихад амжилтгүй боллоо


shader-load-failed and video-load-failed contain a stray "4" ("-аас4"), which will show up in the UI and looks like an accidental typo. Remove the extra character so the message reads naturally (and matches the { $path } placeholder usage in other locales).

Suggested change

shader-load-failed = { $path }-аас4 шейдер ачаалахад амжилтгүй боллоо

shader-not-found = Урьдчилан тохируулсан шейдер олдсонгүй { $shader }

effect-location = Идэвхтэй байна #{ $id }

video-load-failed = { $path }-аас4 видео уншихад амжилтгүй боллоо

shader-load-failed = { $path }-аас шейдер ачаалахад амжилтгүй боллоо

shader-not-found = Урьдчилан тохируулсан шейдер олдсонгүй { $shader }

effect-location = Идэвхтэй байна #{ $id }

video-load-failed = { $path }-аас видео уншихад амжилтгүй боллоо

Copilot · 2026-03-08T17:18:37Z

prpr/locales/mn-MN/parser.ftl

+judge-line-location = In judge line #{ $jlid }
+
+# rpe
+type-events-parse-failed = { $type } үйл явдлуудыг задлахад амжилтгүй боллоо
+incline-events-parse-failed = Хэвгий үйл явдлуудыг задлахад амжилтгүй боллоо
+paint-events-parse-failed = Будагны үйл явдлуудыг задлахад амжилтгүй боллоо
+text-events-parse-failed = Текстний үйл явдлуудыг задлахад амжилтгүй боллоо
+color-events-parse-failed = Өнгөний үйл явдлуудыг задлахад амжилтгүй боллоо
+gif-events-parse-failed = GIF-ний үйл явдлуудыг задлахад амжилтгүй боллоо
+
+illustration-load-failed = { $path }-т байгаа зургийг ачаалахад амжилтгүй боллоо
+gif-load-failed = { $path }-т байгаа GIF-ийг ачаалахад амжилтгүй боллоо
+
+judge-line-location-name = In judge line #{ $jlid } ({ $name })


These two messages are still in English ("In judge line …"), while the rest of the file is Mongolian. If this locale is intended to be fully translated, consider translating these strings for consistency.

Copilot · 2026-03-08T17:18:37Z

prpr/locales/mn-MN/parser.ftl

+no-notes-inserted = No note has been inserted yet
+unknown-command = Unknown command: { $cmd }
+bp-error = Bpm events (bp) should be contiguous and in the head of the file


no-notes-inserted/unknown-command/bp-error are left in English, and no-notes-inserted's wording differs from the en-US meaning (it reads like an editor action rather than “no notes appear in the chart”). This may confuse users; consider translating these and aligning the phrasing with en-US.

Copilot · 2026-03-08T17:18:38Z

phira/locales/mn-MN/chart_order.ftl

+rev-time = Цагаар өсөх.
+name = Нэрээр өсөх.
+rev-name = Нэрээр буурах.
+rating = Үнэлгээгээр буурах.
+rev-rating = Үнэлгээгээр өсөх.


This file defines rev-* keys that are not referenced by phira/src/scene/chart_order.rs, and it is missing the difficulty key that the code does request (tl!("difficulty")). As-is, the difficulty label will fall back to another locale (or show the key), and the extra keys add dead translations—consider adding difficulty and removing unused rev-* entries (or updating the code to use them if intended).

Suggested change

rev-time = Цагаар өсөх.

name = Нэрээр өсөх.

rev-name = Нэрээр буурах.

rating = Үнэлгээгээр буурах.

rev-rating = Үнэлгээгээр өсөх.

name = Нэрээр өсөх.

rating = Үнэлгээгээр буурах.

difficulty = Хүндшлээр буурах.

Copilot · 2026-03-08T17:18:38Z

phira/locales/mn-MN/message.ftl

+
+load-msg-fail = Мессежүүдийг ачаалахад амжилтгүй боллоо
+no-msg = Одоогоор юу ч байхгүй
+subtitle = { $author } at { $time }


subtitle keeps the English word "at" in the middle of the Mongolian string. Other locales translate this connector (e.g., zh-CN uses “于”), so this will look inconsistent in mn-MN; consider translating it or rephrasing the subtitle format.

Copilot · 2026-03-08T17:18:38Z

phira/locales/mn-MN/multiplayer.ftl

+msg-start-playing = Game Start
+msg-played = `{ $user }` тоглоод дууссан: { $score } ({ $accuracy }){ $full-combo ->
+  [true] , full combo
+  *[other] {""}


msg-start-playing and the { $full-combo } branch still contain English (“Game Start”, “full combo”). For a mn-MN locale these will stand out as untranslated; consider translating them (and optionally matching the punctuation style of en-US, which uses “Game started.” / “full combo.”).

b114514 and others added 11 commits August 28, 2024 19:40

add mn-MN. (Mongolian)

e21d328

Update song.ftl

111ad7d

Updated prpr

ff2d8a7

Update home.ftl

4d2ddd9

Update collection.ftl

5d5a9d4

Did parser.ftl (thumbs up)

fce14ea

future relics translated

e0ebbbf

fixed some things

ce282bf

Merge branch 'main' of https://github.com/b114514/phira

798e224

chore: Merge branch 'main' into pr/393

a411409

chore(L10n): add Mongolian language support and new locale files

61931a1

Copilot AI reviewed Mar 8, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(L10n): Add mn-MN translation. (Cyrillic Mongolian)#393

chore(L10n): Add mn-MN translation. (Cyrillic Mongolian)#393
b114514 wants to merge 11 commits intoTeamFlos:mainfrom
b114514:main

b114514 commented Aug 28, 2024

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 8, 2026

Uh oh!

Copilot AI Mar 8, 2026

Uh oh!

Copilot AI Mar 8, 2026

Uh oh!

Copilot AI Mar 8, 2026

Uh oh!

Copilot AI Mar 8, 2026

Uh oh!

Copilot AI Mar 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

b114514 commented Aug 28, 2024

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants