Skip to content

Fix subscriptions import from YT as zip or standaolne .csv file#13535

Open
shirrumon wants to merge 1 commit into
TeamNewPipe:devfrom
shirrumon:fix-yt-takeout-zip-or-csv-subs-import
Open

Fix subscriptions import from YT as zip or standaolne .csv file#13535
shirrumon wants to merge 1 commit into
TeamNewPipe:devfrom
shirrumon:fix-yt-takeout-zip-or-csv-subs-import

Conversation

@shirrumon
Copy link
Copy Markdown

@shirrumon shirrumon commented May 24, 2026

What is it?

  • Bugfix (user facing)
  • Feature (user facing) ⚠️ Your PR must target the refactor branch
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • record videos
  • create clones
  • take over the world

Before/After Screenshots/Screen Record

  • Before:
before_fix.mp4
  • After:
after_fix.mp4

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

I also tested the change locally on an emulator/device.

Tested:

  • Built the debug APK successfully.
  • Installed the APK on an emulator/device.
  • Tried importing a YouTube Takeout subscriptions CSV/ZIP.
  • Confirmed that a valid subscriptions CSV is no longer rejected only because Android reports it as application/octet-stream.
  • Confirmed that the import worker no longer crashes with IndexOutOfBoundsException when the import result is empty.

Due diligence

@github-actions github-actions Bot added the size/medium PRs with less than 250 changed lines label May 24, 2026
@shirrumon
Copy link
Copy Markdown
Author

This fix is related to #13442

@ShareASmile

This comment was marked as resolved.

@ShareASmile ShareASmile added bug Issue is related to a bug import/export Anything related to import/export of data and subscriptions YouTube Service, https://www.youtube.com/ labels May 24, 2026
@shirrumon

This comment was marked as resolved.

@ShareASmile

This comment was marked as resolved.

@ShareASmile
Copy link
Copy Markdown
Collaborator

ShareASmile commented May 24, 2026

Here is the feedback after trying the apk by the user and it doesn't work!

You should handle importing the subscriptions from YouTube & import failing from a previous subscription backup file issue (#13442) separately, preferably in two separate PRs.

Our priority is #13442 and investigation & guidance given by @Stypox in this #13347 (comment) is of important value, following the hack code given in the comment cannot be the permanent solution. Let us see what our team devs has to say on this?
@TobiGr @Stypox

@shirrumon
Copy link
Copy Markdown
Author

Here is the feedback after trying the apk by the user and it doesn't work!

You should handle importing the subscriptions from YouTube & import failing from a previous subscription backup file issue (#13442) separately, preferably in two separate PRs.

Our priority is #13442 and investigation & guidance given by @Stypox in this #13347 (comment) is of important value, following the hack code given in the comment cannot be not the permanent solution. Let us see what our team devs has to say on this? @TobiGr @Stypox

Ok, thank you for Your response! I will deep investigate to solve the problem and i will send full fixes version as new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue is related to a bug import/export Anything related to import/export of data and subscriptions size/medium PRs with less than 250 changed lines YouTube Service, https://www.youtube.com/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[YouTube] Subscriptions import fails under certain scenarios

2 participants