Fix LIVE_STREAM_OFFLINE showing generic 'Content unavailable' error#13541
Open
Manthann-05 wants to merge 1 commit into
Open
Fix LIVE_STREAM_OFFLINE showing generic 'Content unavailable' error#13541Manthann-05 wants to merge 1 commit into
Manthann-05 wants to merge 1 commit into
Conversation
- Detect LIVE_STREAM_OFFLINE in ContentNotAvailableException and show a user-friendly message with YouTube's start-time hint if available - Mark LIVE_STREAM_OFFLINE errors as non-reportable (expected behavior) - Auto-retry loading after 60s so user doesn't have to tap Retry - Cancel pending auto-retry on navigation or manual reload - Fix ConcurrentModificationException in Bandcamp error filtering Fixes TeamNewPipe#13539
ShareASmile
added
the
template ignored
Collaborator
|
Please restore the default PR template and properly fill it out and follow our contribution guidelines! Issue you linked to the PR has been closed as duplicate & build is failing due to checkstyle issue, can you check both! |
ShareASmile
added
feature request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes the bug where opening a scheduled YouTube live stream that hasn't
started yet shows a generic "Content unavailable" error.
Changes
ErrorInfo.kt: DetectLIVE_STREAM_OFFLINEinContentNotAvailableExceptionand extract YouTube's start-time hint for a meaningful error message
VideoDetailFragment.java: Auto-retry after 60s when stream is not started yet;properly cancel the timer on navigation/manual reload
strings.xml: Two new strings for the live-stream-offline stateConcurrentModificationExceptionrisk in Bandcamp error filteringTesting
Tested by opening a scheduled YouTube live stream URL before it goes live.
Before: "Content unavailable" (monkey screen)
After: "This live stream starts in: This live event will begin in X minutes."
with Retry button and auto-reload after 60 seconds.
Closes #13539