Add possibility to remove items using long press,#13580
Open
rcg67gtv wants to merge 3 commits into
Open
Conversation
from tab list and Peertube instance list, for devices that do not support drag and drop, e.g. Android TV.
97e8fa1 to
712ea5b
Compare
Member
|
Thank you for your contribution to NewPipe. For all future PRs, please follow contribution guidelines:
You have not done this. Also this solution does not fix #12635, it only partly addresses it. If the goal is to improve UX for TV users, it would be better to just have buttons on the item itself to delete instead of having to long press: since the drag icon is useless anyway in this scenario. Likewise to have buttons to move item up/down: like ⬆⬇❌ on each item, and for deletes to either have a confirmation, or have a way to undo it if you delete by accident (preferably the second). |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
refactorbranchDescription of the changes in your PR
Before/After Screenshots/Screen Record
Related issues
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence