Use java 21 toolchain on whole extractor and set java via release#1440
Open
dustdfg wants to merge 1 commit intoTeamNewPipe:devfrom
Open
Use java 21 toolchain on whole extractor and set java via release#1440dustdfg wants to merge 1 commit intoTeamNewPipe:devfrom
dustdfg wants to merge 1 commit intoTeamNewPipe:devfrom
Conversation
Toolchain specifies which exact jdk version used for compiling gradle projects. Using several different toolchains in one repo without any reason is wastedul. Unifying used jdk will allow to store only one jdk on dev side. As a side effect unification should make problem encountered by some users on Matrix (it was tried to solve it in #12923)
Contributor
Author
|
Resources for reading: Big and a bit messy https://docs.gradle.org/current/userguide/toolchains.html |
Contributor
Author
|
Both extractor and newpipe probably should use the same toolchain version and just set different language versions..(?) |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toolchain specifies which exact jdk version used for compiling gradle projects. Using several different toolchains in one repo without any reason is wastedul. Unifying used jdk will allow to store only one jdk on dev side. As a side effect unification should make problem encountered by some users on Matrix (it was tried to solve it in #12923)