Skip to content

fix: default preferHls to true on Safari #4236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johnpc wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix: default preferHls to true on Safari #4236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
676fd91
fix: default preferHls to true on Safari
johnpc May 17, 2026
d5bcc23
ci: specify node-version 22 for pnpm compatibility
johnpc May 17, 2026
852610a
chore: add explanatory comments for Safari HLS default
johnpc May 17, 2026
2ec8e99
ci: pin pnpm to major version 10
johnpc May 17, 2026
91289d5
style: fix comment indentation
johnpc May 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,11 @@ jobs:
- name: Setup pnpm
uses: pnpm/action-setup@v5
with:
version: latest
version: 10
- name: Setup Node.js
uses: actions/setup-node@v6
with:
node-version: 22
cache: "pnpm"
- run: pnpm install
- run: pnpm build
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/reviewdog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,11 @@ jobs:
- name: Setup pnpm
uses: pnpm/action-setup@v5
with:
version: latest
version: 10
- name: Setup Node.js
uses: actions/setup-node@v6
with:
node-version: 22
cache: "pnpm"
- run: pnpm install
- uses: reviewdog/action-eslint@v1
Expand Down
7 changes: 5 additions & 2 deletions src/components/VideoPlayer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,6 +587,8 @@ async function loadVideo() {
streams.push(...props.video.videoStreams);

const MseSupport = window.MediaSource !== undefined || window.ManagedMediaSource !== undefined;
// Safari has limited MSE/DASH support, so we default to native HLS playback.
const isSafari = /^((?!chrome|android).)*safari/i.test(navigator.userAgent);

const lbry = null;

Expand All @@ -600,7 +602,7 @@ async function loadVideo() {
props.video.audioStreams.length > 0 &&
!lbry &&
MseSupport &&
!getPreferenceBoolean("preferHls", false)
!getPreferenceBoolean("preferHls", isSafari)
) {
if (!props.video.dash) {
const dash = (await import("../utils/DashUtils.js")).generate_dash_file_from_formats(
Expand Down Expand Up @@ -638,7 +640,8 @@ async function loadVideo() {
return response.headers.get("Content-Type");
});
mime = contentType;
} else if (props.video.dash && !getPreferenceBoolean("preferHls", false)) {
// Safari defaults to HLS due to limited MSE/DASH support (see isSafari above).
} else if (props.video.dash && !getPreferenceBoolean("preferHls", isSafari)) {
uri = props.video.dash;
mime = "application/dash+xml";
} else if (props.video.hls) {
Expand Down