support for newer kernels / Ubuntu 20.04#27
Open
nbuechner wants to merge 25 commits intoTeamSpeak-Systems:masterfrom
Open
support for newer kernels / Ubuntu 20.04#27nbuechner wants to merge 25 commits intoTeamSpeak-Systems:masterfrom
nbuechner wants to merge 25 commits intoTeamSpeak-Systems:masterfrom
Conversation
Contributor
nwerensteijn
left a comment
nwerensteijn
left a comment
There was a problem hiding this comment.
I am not sure if it is a good idea to merge this commit
src/ts3init_target.c
Outdated
| return NF_DROP; | ||
|
|
||
| return NF_CONTINUE; | ||
| return XT_CONTINUE; |
Contributor
There was a problem hiding this comment.
These were changed from NF_ACCEPT to XT_CONTINUE. This would change the way these matches work, since right now it is expected that a packet stops traversing the chain once it matches this rule. Is there a good reason to do this?
src/ts3init_target.c
Outdated
| return NF_DROP; | ||
|
|
||
| return NF_CONTINUE; | ||
| return XT_CONTINUE; |
Contributor
nwerensteijn
left a comment
nwerensteijn
left a comment
There was a problem hiding this comment.
Unclear reason for change
src/ts3init_target.c
Outdated
Comment on lines
+190
to
+194
| if (unlikely(ip_route_me_harder(par_net(par), skb->sk, skb, RTN_UNSPEC) != 0)){ | ||
| #else | ||
| if (unlikely(ip_route_me_harder(par_net(par), skb, RTN_UNSPEC) != 0)){ | ||
| if (ip_route_me_harder(par_net(par), skb, RTN_UNSPEC) != 0){ |
Contributor
There was a problem hiding this comment.
Why remove the unlikely here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pull request as requested via support ticket