Conversation
KMojek
approved these changes
May 12, 2025
src/mp4file.cpp
Outdated
| msg << "no such property - " << name; | ||
| throw new Exception( msg.str(), __FILE__, __LINE__, __FUNCTION__ ); | ||
| log.errorf( "MP4File::FindIntegerProperty - %s", msg.str().c_str() ); | ||
| return; |
Contributor
There was a problem hiding this comment.
FWIW, I think throwing was the original behavior here.
Contributor
Author
There was a problem hiding this comment.
yeah this revert (Revert A) gets undone in the next revert (Revert B), it's a bit confusing here 😁 but if I only reverted that next commit (Revert B) there would have been a conflict with this commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return to original exception throwing flow in mp4.cpp
Goes beyond what I did here: #82
Reverts this commit:
7104b13
And a smaller commit that undid some of that:
56cf37f