Golden gate updates - #13
Open
hoolrory wants to merge 13 commits into
Open
Conversation
> PLCrashAsyncLinkedList.hpp:155:5: 'OSSpinLock' is deprecated: first deprecated in macOS 10.12 - Use os_unfair_lock() from <os/lock.h> instead
PLCrashAsyncLinkedList.hpp:214:9: 'OSMemoryBarrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_thread_fence() from <atomic> instead
PLCrashReporter.m:376:10: 'OSAtomicCompareAndSwap32' is deprecated: first deprecated in macOS 10.12 - Use atomic_compare_exchange_strong_explicit(memory_order_relaxed) from <stdatomic.h> instead
PLCrashMachExceptionServer.m:808:5 'OSAtomicCompareAndSwap32Barrier' is deprecated: first deprecated in macOS 10.12 - Use atomic_compare_exchange_strong() from <stdatomic.h> instead
PLCrashLogWriter.m:446:21 'gestaltSystemVersionMajor' is deprecated: first deprecated in macOS 10.8 - Use NSProcessInfo's operatingSystemVersion property instead.
PLCrashAsyncImageList.cpp:209:5: 'OSAtomicCompareAndSwapPtrBarrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_compare_exchange_strong() from <atomic> instead PLCrashAsyncLinkedList.hpp:414:9: 'OSAtomicIncrement32Barrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_fetch_add() from <atomic> instead PLCrashAsyncLinkedList.hpp:417:9: 'OSAtomicDecrement32Barrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_fetch_sub() from <atomic> instead
There was a problem hiding this comment.
Pull request overview
This PR updates PLCrashReporter’s Apple-platform compatibility by raising the macOS deployment target and replacing deprecated atomic/OS-version APIs with modern equivalents.
Changes:
- Replace deprecated
OSAtomic*/OSMemoryBarrierusage with C11 atomics (<stdatomic.h>) and C++ atomics where applicable. - Replace deprecated
GestaltOS version probing withNSProcessInfo.operatingSystemVersion. - Update Xcode project settings (including
MACOSX_DEPLOYMENT_TARGET = 14.0) and remove some project file entries.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| Source/PLCrashReporter.m | Replaces OSAtomic CAS in uncaught exception handler with C11 atomics. |
| Source/PLCrashReport.m | Minor formatting/indentation adjustment. |
| Source/PLCrashMachExceptionServer.m | Migrates stop-flag synchronization from OSAtomic to C11 atomics. |
| Source/PLCrashLogWriter.m | Replaces Gestalt OS version retrieval and OS memory barriers with modern APIs/atomics. |
| Source/PLCrashAsyncLinkedList.hpp | Replaces OSSpinLock/refcount OSAtomic ops with os_unfair_lock + std::atomic. |
| Source/PLCrashAsyncImageList.cpp | Replaces OSAtomic pointer CAS with a C++ atomic CAS approach. |
| CrashReporter.xcodeproj/project.pbxproj | Bumps macOS deployment target and adjusts target membership entries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
5724
to
5726
| HEADER_SEARCH_PATHS = "\"$(SRCROOT)/Dependencies/protobuf-c\""; | ||
| MACOSX_DEPLOYMENT_TARGET = 10.7; | ||
| MACOSX_DEPLOYMENT_TARGET = 14.0; | ||
| ONLY_ACTIVE_ARCH = NO; |
Comment on lines
5776
to
5778
| HEADER_SEARCH_PATHS = "\"$(SRCROOT)/Dependencies/protobuf-c\""; | ||
| MACOSX_DEPLOYMENT_TARGET = 10.7; | ||
| MACOSX_DEPLOYMENT_TARGET = 14.0; | ||
| OTHER_CFLAGS = ( |
Comment on lines
3904
to
3908
| 05BEC42817BD4F290082CBFB /* PLCrashAsyncMachExceptionInfo.c in Sources */, | ||
| 05BEC43C17BF1CB10082CBFB /* PLCrashReporterConfig.m in Sources */, | ||
| 05A5E28A17C04188008A75E5 /* PLCrashAsyncLinkedList.cpp in Sources */, | ||
| 1F14AC832BACB4330037FCD3 /* CPPCrashHelper.mm in Sources */, | ||
| 05B929EE17C9336600B051E3 /* PLCrashUncaughtExceptionHandler.m in Sources */, | ||
| 0513E23A17D15ED400727919 /* PLCrashReportMachExceptionInfo.m in Sources */, |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update deployment target to 14.0
Replace deprecated classes/method uses