Add new compareScreenshot function that receives a SemanticsNodeInteraction#11
Merged
Conversation
jeslat
commented
Oct 24, 2025
Comment on lines
-7
to
+12
| runs-on: ubuntu-latest | ||
| runs-on: [ self-hosted-org, linux ] |
Contributor
Author
There was a problem hiding this comment.
Changing this workflow to run in internal runners as this repo is private
jeslat
commented
Oct 24, 2025
| @@ -0,0 +1,44 @@ | |||
| name: "Create snapshot" | |||
Contributor
Author
There was a problem hiding this comment.
I've added a workflow to generate snapshots
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new compareScreenshot overload that accepts a SemanticsNodeInteraction parameter, enabling more granular screenshot testing of specific UI nodes. It also integrates disableFlakyComponentsAndWaitForIdle() into all screenshot comparison functions and establishes a snapshot release workflow.
- Added new
compareScreenshot(SemanticsNodeInteraction, String?)function for capturing screenshots of specific semantics nodes - Integrated
disableFlakyComponentsAndWaitForIdle()into allcompareScreenshotvariants for improved test stability - Created snapshot workflow and updated CI infrastructure to use Docker image version 13
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| android-snaptesting/src/main/java/com/telefonica/androidsnaptesting/screenshots/ScreenshotsRule.kt | Added new compareScreenshot overload accepting SemanticsNodeInteraction and integrated disableFlakyComponentsAndWaitForIdle() calls |
| .github/workflows/snapshot.yml | Created new workflow for publishing snapshot versions of library and plugin |
| .github/workflows/release.yml | Updated Docker image version from 12 to 13 |
| .github/workflows/preintegration.yml | Updated to use self-hosted runner with Docker image version 13 and added concurrency controls |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
jeslat
requested review from
a team,
dnieto-r and
hjorrod
and removed request for
a team
hjorrod
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🥅 What's the goal?
Add new
compareScreenshotfunction that receives aSemanticsNodeInteractionlike Shot has to use it in B2P.I've also included
disableFlakyComponentsAndWaitForIdle()in all thecompareScreenshotfunctions.🧪 How can I test this?
I can't test it because we don't have a workflow to generate snapshots (I've added it in this PR). I will test it in B2P as soon as the release is generated.