fix(hermes): install memory provider in user plugin dir#169
Closed
siolyn wants to merge 1 commit into
Closed
Conversation
Signed-off-by: siolyn <siolynn@outlook.com>
Author
|
Superseded by #170 using a non-codex branch prefix. |
Collaborator
|
Received, we will follow #170. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #167.
The Hermes installer previously linked
memory_tencentdbonly into the mutable Hermes checkout tree:$HERMES_AGENT_DIR/plugins/memory/memory_tencentdbIf the Hermes checkout is replaced during an update, that symlink can disappear while
memory.provider: memory_tencentdbremains configured, causing TencentDB memory to silently detach.This PR keeps the checkout link for compatibility and also installs a durable user-scope memory provider link:
$HERMES_HOME/plugins/memory_tencentdbHermes memory provider discovery scans
$HERMES_HOME/plugins/<provider_name>/, so this is the path that survives checkout replacement.Changes
readlinkresults in the install summary.Verification
bash -n scripts/install_hermes_memory_tencentdb.shgit diff --checkHERMES_HOME/HERMES_AGENT_DIRplugin.yamlNote: the local smoke-test run reached the symlink step successfully, then stopped at the pre-existing
/etc/profile.dsudo write because this macOS test environment requires an interactive sudo password.