[good first issue] fix(embedding): enable retry backoff for embedding API calls#173
Open
zhangxiaoshuai98 wants to merge 1 commit into
Open
Conversation
MAX_RETRIES was hardcoded to 0, making the existing exponential backoff retry logic dead code. Transient errors (network jitter, 429 rate limits, DNS failures) caused immediate embedding failure, contributing to JSONL/SQLite drift (issue TencentCloud#156). Changed MAX_RETRIES from 0 to 3, matching the retry strategy already used by tcvdb-client.ts. Closes TencentCloud#159 Signed-off-by: WSL_zhangxiaoshuai <zhangxiaoshuai@wsl.com>
Collaborator
|
Thanks for fixing the retry logic! Transient errors should definitely trigger retries. This will improve embedding reliability significantly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #159
MAX_RETRIESwas hardcoded to0insrc/core/store/embedding.ts, making the existing exponential backoff retry logic dead code. Transient errors (network jitter, 429 rate limits, DNS failures) caused immediate embedding failure.Changes
MAX_RETRIESfrom0to3insrc/core/store/embedding.tstimeoutMsdescription inopenclaw.plugin.jsonto reflect retry behaviorRetry behavior (after fix)
This matches the retry strategy already used by
tcvdb-client.ts(MAX_RETRIES = 2).Verification
npm run build— passednpm test— 38 tests passed🤖 Generated with Claude Code