fix: three high-quality bug fixes#263
Open
Ricardo-M-L wants to merge 1 commit intoTencentCloudADP:mainfrom
Open
fix: three high-quality bug fixes#263Ricardo-M-L wants to merge 1 commit intoTencentCloudADP:mainfrom
Ricardo-M-L wants to merge 1 commit intoTencentCloudADP:mainfrom
Conversation
1. Security: SQL injection in PhoenixUtils.get_trace_url_by_id Escape single quotes to prevent filter expression injection. 2. Security: path traversal in FileEditLocal._resolve_filepath Add work_dir boundary check before returning resolved path. 3. Logic: wrong variable in BaseBenchmark.preprocess_one Save and return processed_sample instead of original sample. 4. Logic: get_next_task returns str instead of Subtask Return None when no tasks available, update return type to Subtask | None. 5. Missing await: worker.run_streamed in _run_task Add await to fix TypeError when accessing result properties. 6. Missing await: Runner.run_streamed in _start_streaming Add await in both branches (trace and no-trace). 7. AssignerAgent.assign_task handles None from get_next_task Return None early when no task available. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three high-quality bug fixes covering security and logic issues:
1. Security: SQL Injection in PhoenixUtils (
utu/tracing/phoenix_utils.py)get_trace_url_by_iddirectly interpolatedtrace_idinto a filter expression string. Escaped single quotes withreplace("'", "''")to prevent injection.2. Security: Path Traversal in FileEditLocal (
utu/tools/local_env/file_edit.py)_resolve_filepathonly sanitized the filename, not parent directory components. Attackers could use../to escape the workspace. Addedresolved_path.relative_to(self.work_dir)check that raisesValueErrorif the path escapes.3. Logic: Wrong Variable in BaseBenchmark (
utu/eval/benchmarks/base_benchmark.py)preprocess_oneprocessed a sample intoprocessed_samplebut then saved and returned the originalsample, discarding the processed result. Fixed to save and returnprocessed_sample.4. Type Bug: get_next_task Returns Wrong Type (
utu/agents/workforce/data.py)get_next_taskreturned"No uncompleted tasks."(a string) instead ofNone, violating its return type annotation. Fixed to returnSubtask | None.5. Missing Await: orchestrator_agent (
utu/agents/orchestrator_agent.py)worker.run_streamed(input)was not awaited, causing TypeError when accessingresult.final_output. Fixed by addingawait.6. Missing Await: simple_agent (
utu/agents/simple_agent.py)Runner.run_streamed(**run_kwargs)was not awaited in both branches (with and without trace). Fixed by addingawaitin both places.7. AssignerAgent: Handle None from get_next_task (
utu/agents/workforce/assigner.py)Updated
assign_taskreturn type toSubtask | Noneand added early return whenget_next_task()returnsNone.Test plan