Clarify Makers dev script usage in skills#5
Merged
Conversation
vincentism
reviewed
Jul 7, 2026
| "scripts": { | ||
| "build": "edgeone makers build", | ||
| "deploy": "edgeone makers deploy" | ||
| "dev": "vite --host 127.0.0.1", |
Collaborator
There was a problem hiding this comment.
如果纯静态项目，给出这样的示例，可能会引导ai包一层vite，会很多余
Document that package scripts should keep frontend dev servers separate from the EdgeOne Makers wrapper to avoid recursive local dev startup. Co-authored-by: Cursor <cursoragent@cursor.com>
- drop SessionStart/UserPromptSubmit/PreToolUse injection+dedup+chainTo - keep validate as standalone stateless validate-write.mjs - hooks.json: PreToolUse on write tools only - strip pathPatterns/bashPatterns/chainTo from SKILL.md (keep pathPatterns on edge-functions as validate scope) - move chainTo cross-refs into SKILL.md prose - mark #6/#7/#8/#9/#12 deprecated in feature.yaml - runtime ~700 -> ~150 lines, 3 hook events -> 1, drop .edgeone state Co-authored-by: Cursor <cursoragent@cursor.com>
- makers-edge-functions pathPatterns: add edge-functions/** (SKILL.md prose uses edge-functions/, old functions/** never matched) - delete unreferenced on-agent-write.sh, on-edgeone-cmd.sh (superseded by validate-write) - add edge-functions path test case Co-authored-by: Cursor <cursoragent@cursor.com>
- add .claude-plugin/marketplace.json (name/owner/plugins, source: ./) - migrate manifest.json -> plugin.json (hooks: ./hooks/hooks.json, author object) - enables /plugin marketplace add + /plugin install edgeone-makers@edgeone-makers - README: document Claude Code marketplace install Co-authored-by: Cursor <cursoragent@cursor.com>
- .codebuddy-plugin/marketplace.json: standard name (edgeone-makers) for public install - codebuddy installs via plugin marketplace like Claude Code Co-authored-by: Cursor <cursoragent@cursor.com>
- align with Cursor official plugin manifest (name/description/version/author object) - skills/hooks auto-discovered from repo root default dirs - drop explicit skills list (default scan skills/) Co-authored-by: Cursor <cursoragent@cursor.com>
…ols plugin) - validate-write.test: expect edgeone-makers-edge-functions (main renamed skills with edgeone- prefix) - marketplace.json (.claude/.codebuddy): plugins[].name edgeone-makers -> edgeone-makers-tools (match plugin.json name) Co-authored-by: Cursor <cursoragent@cursor.com>
… from PR review #5 feedback: - drop duplicated dev/package.json scripts guidance across skills (CLI handles compat) - remove vite examples that could mislead AI into wrapping static projects - keep CLI command refs (makers dev/build) and preview rules; untouched - restore Claude Code marketplace install option in README - remove docs/plugin-hooks-vs-context-and-tools.md and features/.../feature.yaml from PR (reviewer: docs should not be submitted) Co-authored-by: Cursor <cursoragent@cursor.com>
QT-7274
force-pushed
the
fix/makers-agent-dev-scripts
branch
from
July 8, 2026 08:34
f752d96 to
809ef8c
Compare
vincentism
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
devscripts must remain frontend dev servers.makers:devguidance for EdgeOne Makers local development across CLI, recipes, framework references, and review checklist.Hooks slim-down (align with
docs/plugin-hooks-vs-context-and-tools.md)hooks/validate-write.mjs;hooks.jsonnow only registers PreToolUse on write tools (Edit|Write|replace_in_file|write_to_file), preserving CodeBuddy tool-name compat.pathPatterns/bashPatterns/chainTofrom SKILL.md frontmatter; keeppathPatternsonmakers-edge-functionsas the validate path scope; move chainTo cross-refs into SKILL.md prose..edgeonestate file dropped.Test plan
devscript patterns.node --test hooks/*.test.mjs→ 12/12 pass (validate-write + signal-log).