Conversation
…perature and humidity
…nager into currentWeatherMethod
…hod, we send the current weather condition depending on the humidity and the temperature
Current weather method
Current weather method
melt, freeze, evaporate
…s the weather depending on the temperature and the humidity
BenjaminAmos
left a comment
BenjaminAmos
left a comment
There was a problem hiding this comment.
Somebody will get around to properly reviewing this at some point but can I just ask that you tidy-up your changes a bit first? You seem to have introduced several random files with content that is completely unrelated to these changes.
You can make updates to this pull request by pushing to the branch it points to.
I've left a few comments from a cursory glance at the changes but this is not yet a full review.
| @@ -0,0 +1 @@ | |||
| sah sah sah No newline at end of file | |||
| @@ -0,0 +1 @@ | |||
| ijfjverzhjbtrkubt:lhbtr No newline at end of file | |||
| @@ -0,0 +1 @@ | |||
| TEjsfsidfjzuifnhnhjdfs No newline at end of file | |||
There was a problem hiding this comment.
I do not believe that this file serves any useful purpose either.
| import org.terasology.climateConditions.ClimateConditionsSystem; | ||
| import org.terasology.climateConditions.ClimateConditionsSystem; |
There was a problem hiding this comment.
Why is this class imported twice?
|
|
||
| @Override | ||
| public void postBegin() { | ||
| networkSystem = context.get(NetworkSystem.class); |
There was a problem hiding this comment.
In general, using @In should be the same as context.get. Did that not work for you?
| @ReceiveEvent | ||
| public void stagnateTemperature(TemperatureStagnateEvent event, EntityRef worldEntity) { | ||
| float temperature = this.currentTemperature; | ||
| //T = (TMAX - TMIN)value + TMIN => value = (T - TMIN)/(TMAX -TMIN) |
There was a problem hiding this comment.
I assume that this is re-arranging the equation but the comment is not clear about what this equation does.
| @@ -0,0 +1,39 @@ | |||
| <!-- This file, when present as src/test/resources/logback-test.xml, | |||
There was a problem hiding this comment.
This file should not be needed. Logging configuration is not typically done at a module level.
| @@ -0,0 +1 @@ | |||
| jsgdhsjfjhiezuyruiz | |||
There was a problem hiding this comment.
This file also appears to serve no use.
| // SPDX-License-Identifier: Apache-2.0 | ||
| package org.terasology.weatherManager.weather; | ||
|
|
||
| import java.util.Random; |
There was a problem hiding this comment.
Why have you added a random import here?
7 participants
Hello, this pull request is made to resolve all the points in the issue #26 .
feat(Temperature) : Temperature which increase, decrease or stagnate. Temperature depends on time
feat(Humidity) : Humidity increase when Temeprature decrease and vice-versa
feat(Water state) : the water will evaporate or freeze according to the temperature. Same with the snow
feat(Weather) : the weather depends on humidity and temperature