fix: pass jump host config to terminal WebSocket connection#13
Closed
ZacharyZcR wants to merge 1 commit into
Closed
fix: pass jump host config to terminal WebSocket connection#13ZacharyZcR wants to merge 1 commit into
ZacharyZcR wants to merge 1 commit into
Conversation
jumpHosts was defined on SSHHost but never included in the TerminalHostConfig interface or passed through Sessions → Terminal → NativeWebSocketManager. The backend received no jump host data so connections that require a jump server always failed on mobile. Fixes Termix-SSH/Support#422
Member
Author
|
Superseded by #15 which includes jumpHosts along with additional missing fields (forceKeyboardInteractive, overrideCredentialUsername). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jumpHostsfield fromSSHHostwas never passed through to the terminal WebSocket connection. TheTerminalHostConfiginterface,TerminalProps, andSessions.tsxall omitted it, so the backend received no jump host data and connections requiring a jump server always failed.Files Changed
app/tabs/sessions/terminal/NativeWebSocketManager.tsjumpHoststoTerminalHostConfiginterfaceapp/tabs/sessions/terminal/Terminal.tsxjumpHoststoTerminalProps.hostConfigapp/tabs/sessions/Sessions.tsxsession.host.jumpHostsin Terminal hostConfig propTest plan
npx tsc --noEmitshows no new type errorsFixes Termix-SSH/Support#422