fix: register physical Tab key on iPadOS hardware keyboards#14
Open
ZacharyZcR wants to merge 1 commit into
Open
fix: register physical Tab key on iPadOS hardware keyboards#14ZacharyZcR wants to merge 1 commit into
ZacharyZcR wants to merge 1 commit into
Conversation
The native module only registered Shift+Tab but not bare Tab, so iOS intercepted it for UI focus navigation. Register an unmodified Tab UIKeyCommand with wantsPriorityOverSystemBehavior and handle both Tab and Shift+Tab in the same JS branch. Fixes Termix-SSH/Support#557
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Shift+TabviaUIKeyCommandbut not bareTab. Without an explicit registration withwantsPriorityOverSystemBehavior, iOS intercepts the Tab key for its own UI focus navigation, so it never reaches the terminal.TabandShift+Tabare now handled in a single branch, sending\tor\x1b[Zrespectively.Files Changed
modules/hardware-keyboard/ios/HardwareKeyboardModule.swiftUIKeyCommandwith priority over systemapp/tabs/sessions/Sessions.tsxTest plan
\x1b[Z)Fixes Termix-SSH/Support#557