Add mobile terminal font selection#19
Open
ZacharyZcR wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add mobile terminal font selection under Settings -> Customize Terminal so users can choose the terminal font family on iOS and Android.
Changes Made
TERMINAL_FONTSoptions in the mobile Terminal Customization screen.fontFamilythroughTerminalCustomizationContext..xterm-screeninstead of overriding it with a fixed Caskaydia stack.Related Issues
Screenshots / Demos
Not included; this is a settings and terminal rendering change that should be verified on iOS/Android with an SSH session using Nerd Font glyphs.
Validation run locally:
npx eslint app/contexts/TerminalCustomizationContext.tsx app/tabs/settings/TerminalCustomization.tsxpasses.npx eslint app/contexts/TerminalCustomizationContext.tsx app/tabs/settings/TerminalCustomization.tsx app/tabs/sessions/terminal/Terminal.tsxpasses with existing Terminal warnings only.npx prettier --check app/contexts/TerminalCustomizationContext.tsx app/tabs/settings/TerminalCustomization.tsx app/tabs/sessions/terminal/Terminal.tsxpasses.git diff --checkpasses.npx tsc --noEmitstill fails on existing repository-wide TypeScript errors outside this change.Checklist